Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anchor link to table events can be hidden by sticky table header #605

Closed
rlskoeser opened this issue May 12, 2020 · 3 comments
Closed

anchor link to table events can be hidden by sticky table header #605

rlskoeser opened this issue May 12, 2020 · 3 comments
Assignees
Labels

Comments

@rlskoeser
Copy link
Contributor

rlskoeser commented May 12, 2020

One observation: this only has happened once, but when I was searching for the "Life and Letters of Emily Dickinson" on Leo Stein's card, when I clicked the card where the event took place it highlighted the event but it was soooo far up at the top of the screen that at first I couldn't see it was highlighted at all. I tried to take a screenshot of it:
Screen Shot 2020-05-07 at 10 47 36 PM
--> if you look up at the very top there's the pale blue highlight but I almost missed it. I think this has something to do with the fact that the borrow is the FIRST on the card? I tried again with other books that appear first on the card and this happened every time. Not a big deal at all, but worth noting if you guys know how to fix it. (Or maybe it's just my small laptop screen's fault?)

Originally posted by @clmahoney in #264 (comment)

Both @rlskoeser and @thatbudakguy looked into this problem, but typical css solutions don't apply here because we're dealing with table elements.

@jkotin
Copy link

jkotin commented Dec 18, 2023

I think this is fixed, but let me know if there are specific instructions for testing.

@rlskoeser
Copy link
Contributor Author

@jkotin sorry I didn't write testing notes. Here's a specific example so you can compare the behavior between production and test and confirm this is fixed:

https://shakespeareandco.princeton.edu/members/bernheim-antoinette/cards/cfd8a318-28a4-47d1-8c14-e06ccec95e7d/#e11218

https://test-shakespeareandco.cdh.princeton.edu/members/bernheim-antoinette/cards/cfd8a318-28a4-47d1-8c14-e06ccec95e7d/#e11218

@jkotin
Copy link

jkotin commented Dec 19, 2023

Excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants