Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design // spacing for and around non-uniform cards #665

Closed
jkotin opened this issue Jun 9, 2020 · 8 comments
Closed

Design // spacing for and around non-uniform cards #665

jkotin opened this issue Jun 9, 2020 · 8 comments
Assignees
Labels

Comments

@jkotin
Copy link

jkotin commented Jun 9, 2020

Not urgent // The spacing is off on https://shakespeareandco.princeton.edu/members/stirling-monica/cards/ -- I also attach a screen shot. I imagine this is due to the irregular size cards.
Screen Shot 2020-06-09 at 9 38 41 AM

@rlskoeser
Copy link
Contributor

Please test https://test-shakespeareandco.cdh.princeton.edu/members/stirling-monica/cards/
Check both desktop or tablet and mobile since mobile differs slightly.

@clmahoney
Copy link

  • NO, I think the spacing if still off. I tried this is on my computer:
    Screen Shot 2020-06-11 at 4 36 00 PM

@clmahoney
Copy link

BUT YES, spacing looks great on mobile!
IMG_2306

@clmahoney
Copy link

OK I tried again after a forced reload and the computer image looks good too:
Screen Shot 2020-06-11 at 4 41 55 PM

@clmahoney
Copy link

Although, I feel like I'm seeing things but I think the spacing still isn't quite the same?

@clmahoney
Copy link

Am I look at spacing between cards or space with the dates beneath?

@rlskoeser
Copy link
Contributor

@clmahoney the most important thing is that the images that are different sizes (I think the last three in this case) display correctly and don't get squished into the usual lending library card size — compare this page on the test site and production (or Josh's screenshot) to see.

@clmahoney
Copy link

Oh I finally see it! Thank you! I compared it to the production site and can clearly see now that the odd-sized images are NOT getting squished anymore!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants