Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events without titles (such as subscriptions) display strangely on card detail pages #712

Closed
i-davis opened this issue Dec 9, 2020 · 1 comment
Closed

events without titles (such as subscriptions) display strangely on card detail pages #712

i-davis opened this issue Dec 9, 2020 · 1 comment
Assignees
@rlskoeser @i-davis
Labels
bug
Milestone
1.3

Comments

@i-davis
Copy link

i-davis commented Dec 9, 2020 •
edited by rlskoeser

testing notes

  • subscription events on card detail pages should display a - for title on desktop (no link)
  • subscription events on mobile should not display the - for a missing title

The card pages currently display subscriptions with an empty line in the title column that is also a link that just sends you back to the same card page. It shouldn't be a link, and shouldn't display on mobile.

Screen Shot 2020-12-09 at 10 29 10 AM
@rlskoeser rlskoeser added bug and removed enhancement labels Dec 9, 2020
@rlskoeser rlskoeser changed the title Change the display of subscriptions on the card pages. events without titles (such as subscriptions) without titles fix display strangely on card detail pages Dec 9, 2020
rlskoeser added a commit that referenced this issue Dec 9, 2020
@rlskoeser
Fix card detail page display for events with no item/title #712
a10423a 
- no link on desktop/tablet
- don't display at all on mobile
@i-davis
Copy link
Author

i-davis commented Dec 10, 2020

Good!

@i-davis i-davis closed this as completed Dec 10, 2020
@rlskoeser rlskoeser added this to the 1.3 milestone Dec 10, 2020
@rlskoeser rlskoeser changed the title events without titles (such as subscriptions) without titles fix display strangely on card detail pages events without titles (such as subscriptions) display strangely on card detail pages Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlskoeser rlskoeser

@i-davis i-davis

Labels
bug
Projects
None yet
Milestone
1.3
Development

No branches or pull requests
2 participants
@rlskoeser @i-davis