-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a user, I want items with the same title and author to be collapsed automatically so that my search isn’t clouded by repetitive results. #445
Comments
Importation functionality: I randomly spot-checked a handful of records to make sure clusters were created according to the script with associated digitized works (can't think of a more comprehensive way to test). Looks good. Logging is working - on the main log it appears in stages (first logging the addition of a cluster, followed by the changes to works added to that cluster via csv). This makes sense to me. Clustering search logic: Can't test all of this yet, but what I did test looks good. A question I have is whether on the main search page if you're just "browsing" (no active search), should the clustered items be collapsed? I feel like they should (maybe that's part of the functionality that isn't working yet?) Cluster icon display: Icon placement looks good to me! I am going to show it to MM. I like that it's in the white box at the top, and "Search the full archive" is a much clearer version of what I was going for. Cluster icon styles: Can't check on my actual phone/tablet because I don't have a PU VPN set up on those devices, but changing my window size on my laptop the styles responded as expected. I'll figure out how to do this by the next round of testing. |
Works within a cluster are being collapsed in browsing mode now, and it looks phenomenal! Meredith wondered if there was too much whitespace to the right of the "You are searching and browsing..." message but it doesn't bother me. I retested the cluster icon styles on iPhone and iPad and they look good to me; on iPhone the "You are searching and browsing within a cluster" message looks a little cramped because of the way it wraps around the icon but not worth fixing IMO. Keyword search is the only thing not working now for this issue (and it's actually not working at all - see my comment on #282). |
@quadrismegistus thank you for your work on this issue! YAY that search is working!! I can search in the main archive page and within clusters as expected. A couple things I noticed.
A couple things are broken -- I'm guessing because of the new code since they're working in production:
I'd like to do another round of testing but thought I'd submit these notes. |
This looks good! I retested with some searches and (1) clusters are now collapsed on browse and (2) search term persists from main to cluster search. The publications and collections filters plus the sort functionality also appear to be working within cluster search. The only question I still had (which we happened to be tracking on this issue) is the discrepancies I noticed b/w QA and production: empty result in ballad search and Gale image thumbnails broken. |
I rechecked the new functionality (search persistence and collapse on browse) to make sure the Gale image fix didn't interfere with anything and it looks like everything is working now! RSK told me the empty ballad result was one of the items in QA that doesn't have pairtree data. |
testing notes
first round testing (keyword search not yet working; sorting within clusters known to be not working)
see designs for multiple editions in Zeplin: https://app.zeplin.io/project/5be36b3d9dcaf67e95d71839/screen/60c3e0a8929ba112f9f6ee0f
dev notes
The text was updated successfully, but these errors were encountered: