Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user viewing a digitized work that's available in other editions, I want to know that other editions are available and have easy access to search across them. #452

Closed
3 tasks done
rlskoeser opened this issue Aug 2, 2022 · 3 comments
Assignees
Milestone

Comments

@rlskoeser
Copy link
Contributor

rlskoeser commented Aug 2, 2022

testing notes

on digitized work detail page on the public site

  • if work is part of cluster, it should have cluster icon and text
    • search and browse link should take you to the search within the appropriate cluster
  • if work is not in a cluster, it should not have the icon or text

dev notes

detail view for a volume with other editions should have icon indicator and access to search across all editions

related to #445 and #451

@rlskoeser rlskoeser added this to the v3.8 milestone Aug 2, 2022
@rlskoeser rlskoeser self-assigned this Aug 17, 2022
@mnaydan
Copy link
Contributor

mnaydan commented Aug 23, 2022

@rlskoeser hm, I can't test the last one because I just noticed the interface is hiding texts that are NOT part of a cluster! I searched by title and author for specific texts I knew weren't part of a cluster and it failed to return the works. I confirmed this behavior by removing hvd.32044090278565 from association with "atestcluster2" on the backend, and the volume then disappeared from the public facing test site.

@rlskoeser
Copy link
Contributor Author

wow, weird! thanks for reporting, will investigate when I circle back

@mnaydan
Copy link
Contributor

mnaydan commented Feb 13, 2023

This looks good -- icon does NOT appear on works not associated with a cluster, and it's not hiding non-cluster works like it was before. Functionality as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants