Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyword search is failing to show more than one term in context #463

Closed
mnaydan opened this issue Aug 17, 2022 · 3 comments
Closed

Keyword search is failing to show more than one term in context #463

mnaydan opened this issue Aug 17, 2022 · 3 comments
Assignees
Labels
Milestone

Comments

@mnaydan
Copy link
Contributor Author

mnaydan commented Aug 29, 2022

@rlskoeser this is better (it's now showing at least three snippets), but the text snippets still work better in current production. In production the snippet starts at the beginning of a sentence and the spacing is natural (which is better if we want users to stay on our site rather than going out to HT/Gale). On the test site the snippets are chunked out with added spaces and often start mid-sentence. If we don't have the capacity to fix it right now it's definitely usable for the release as is, just a shame to lose functionality that was working so well! See the screenshots for comparison:
Test: Screen Shot 2022-08-29 at 10 57 51 AM
Production:Screen Shot 2022-08-29 at 10 57 59 AM
Test:
Screen Shot 2022-08-29 at 11 00 23 AM
Production:
Screen Shot 2022-08-29 at 11 00 32 AM

@rlskoeser
Copy link
Contributor

rlskoeser commented Sep 2, 2022

@mnaydan I compared the solr queries and responses on the test and production Solr instances: the queries and responses seem to me like they are exactly the same. I can't explain in the difference in display that you're seeing.

In my opinion, this isn't worth holding the release up. I propose we move forward with releasing the updated Gale/ECCO functionality and if this continues to be a problem in production, we can open an issue to look into it again the next time we're in active development.

@mnaydan
Copy link
Contributor Author

mnaydan commented Sep 2, 2022

@rlskoeser thanks for taking the time to look into it! That sounds good to me. I'll close and we can do the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants