Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'uncategorized' collections button appears even when there are no uncategorized works #542

Closed
mnaydan opened this issue Aug 1, 2023 · 1 comment
Closed

'uncategorized' collections button appears even when there are no uncategorized works #542

mnaydan opened this issue Aug 1, 2023 · 1 comment
Assignees
@rlskoeser
Labels
bug

Comments

@mnaydan
Copy link
Contributor

mnaydan commented Aug 1, 2023 •
edited by rlskoeser

testing notes

  • use the public search to identify the three uncategorized works, and add them to collections
  • refresh the archive search (may require a hard refresh) and confirm that the uncategorized collection goes away
@mnaydan mnaydan added the bug label Aug 1, 2023
rlskoeser added a commit that referenced this issue Feb 29, 2024
@rlskoeser
Don't display uncategorized collection in search if facet count is zero
9a25d25 
fixes #542
@rlskoeser rlskoeser self-assigned this Feb 29, 2024
@mnaydan
Copy link
Contributor Author

mnaydan commented Mar 1, 2024

@rlskoeser tested and confirmed!

@mnaydan mnaydan closed this as completed Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlskoeser rlskoeser

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rlskoeser @mnaydan