Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After clicking "Search the full archive" from a cluster page, cluster urls aren't removed when linking to another cluster #544

Closed
mnaydan opened this issue Aug 24, 2023 · 1 comment
Closed

After clicking "Search the full archive" from a cluster page, cluster urls aren't removed when linking to another cluster #544

mnaydan opened this issue Aug 24, 2023 · 1 comment
Assignees
@rlskoeser
Labels
bug

Comments

@mnaydan
Copy link
Contributor

mnaydan commented Aug 24, 2023 •
edited

We noticed this bug because there was a 503 error reporting "the website is under heavy load (queue full)". We checked with PUL and they said we needed to restart the app, which resolved the problem. But the log has a lot of entries with a bing bot crawling the site, hitting the archive page with multiple clusters repeated in the url (like this)

The problem URL is this one: https://prosody.princeton.edu/archive/?cluster=&page=1, which you get to by moving from searching within a cluster to clicking "Search the full archive." Rebecca and I agree that clicking "Search the full archive" should just take you to https://prosody.princeton.edu/archive/. I don't think it's necessary for search terms and parameters to be preserved in this instance, personally, especially if it is substantially more work.
@mnaydan mnaydan added the bug label Aug 24, 2023
@rlskoeser rlskoeser self-assigned this Aug 24, 2023
@rlskoeser rlskoeser self-assigned this Feb 6, 2024
rlskoeser added a commit that referenced this issue Feb 6, 2024
@rlskoeser
Fix link to main archive search from search within cluster
374d393 
fixes #544
@rlskoeser rlskoeser mentioned this issue Feb 6, 2024
Merged
rlskoeser added a commit that referenced this issue Feb 8, 2024
@rlskoeser
Fix link to main archive search from search within cluster (#584)
9c30184 
* Fix link to main archive search from search within cluster

fixes #544

* Mark querystring_replace result as safe to avoid urlencoding

* Simplify cluster fixtures and test

* Simplify test for search sort with clusters

* Test search within cluster appropriately limits works
@mnaydan
Copy link
Contributor Author

mnaydan commented Feb 12, 2024

I can confirm that reproducing the above steps on the test site now brings us back to the https://test-prosody.cdh.princeton.edu/archive/ URL as desired.

@mnaydan mnaydan closed this as completed Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlskoeser rlskoeser

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rlskoeser @quadrismegistus @mnaydan