Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't print more than one page of editorial essay #548

Closed
mnaydan opened this issue Aug 28, 2023 · 6 comments
Closed

Can't print more than one page of editorial essay #548

mnaydan opened this issue Aug 28, 2023 · 6 comments
Assignees
Labels

Comments

@mnaydan
Copy link
Contributor

mnaydan commented Aug 28, 2023

Attempting to print an editorial essay only allows the user to print out whatever fits on one page, and the user is unable to save as PDF or print out the rest of the content. Rebecca believes we had a one-page problem like this before on another site and that it is an overflow setting.

@mnaydan
Copy link
Contributor Author

mnaydan commented Sep 1, 2023

@rlskoeser this looks great! The entire essays are saveable/printable and span multiple pages: they're readable, sequential, and laying out as expected. And even links are preserved!

Two small things:

  1. There are two extra blank pages at the end of each piece when you save/print it.
  2. Is there a way to scale images? Not an issue for Meredith's pieces, so maybe something we track to implement later. For instance, in Gissoo's essay the floated images are huge and take up the entire page.

@rlskoeser
Copy link
Contributor

@mnaydan yes, we can implement different styles for images for print css - let's track that as a new feature and put it off for now.

Not sure about the blank pages! There may be some hidden stuff that is taking up space; I'm inclined to work around that for now, since we can fairly easily remove them for the PDFs we generate in the short term. I'm still investigating better PDF generation that includes header and footer styles like we have for Startwords, but I was having trouble with the tools that do that.

@mnaydan
Copy link
Contributor Author

mnaydan commented Sep 1, 2023

OK! I think for the purposes then, this is great and we can close & track in new feature.

@rlskoeser
Copy link
Contributor

oh, weird, it's the hidden print stuff that I'm trying to put in the headers and footers but haven't been able to try (browsers don't support the CSS paged media spec fully). I'll see if there's a simple fix

@rlskoeser
Copy link
Contributor

@mnaydan I have a fix for the blank space at the end if you want to confirm

@mnaydan
Copy link
Contributor Author

mnaydan commented Sep 1, 2023

@rlskoeser ooh, yes! The blank pages are gone! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants