-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't print more than one page of editorial essay #548
Comments
@rlskoeser this looks great! The entire essays are saveable/printable and span multiple pages: they're readable, sequential, and laying out as expected. And even links are preserved! Two small things:
|
@mnaydan yes, we can implement different styles for images for print css - let's track that as a new feature and put it off for now. Not sure about the blank pages! There may be some hidden stuff that is taking up space; I'm inclined to work around that for now, since we can fairly easily remove them for the PDFs we generate in the short term. I'm still investigating better PDF generation that includes header and footer styles like we have for Startwords, but I was having trouble with the tools that do that. |
OK! I think for the purposes then, this is great and we can close & track in new feature. |
oh, weird, it's the hidden print stuff that I'm trying to put in the headers and footers but haven't been able to try (browsers don't support the CSS paged media spec fully). I'll see if there's a simple fix |
@mnaydan I have a fix for the blank space at the end if you want to confirm |
@rlskoeser ooh, yes! The blank pages are gone! :) |
Attempting to print an editorial essay only allows the user to print out whatever fits on one page, and the user is unable to save as PDF or print out the rest of the content. Rebecca believes we had a one-page problem like this before on another site and that it is an overflow setting.
The text was updated successfully, but these errors were encountered: