Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user, I want to download a PDF and cite a published editorial so that I can deposit it or share it in a more recognized academic format. #550

Closed
4 tasks done
rlskoeser opened this issue Sep 1, 2023 · 8 comments
Assignees

Comments

@rlskoeser
Copy link
Contributor

rlskoeser commented Sep 1, 2023

adapt print styles from startwords; related to #548

testing notes

  • optional doi field for editorials; should display on editorial page when set
  • optional pdf link for editorials; should display link on editorial page when set
  • print preview should suppress PPA headers and footers, adjust margins and font sizes, hide PDF link if any
  • try harvesting from zotero and see what the citation looks like; should include doi when set (author orcid is in the header metadata if we have it, but I'm not sure zotero pulls that)
@rlskoeser rlskoeser self-assigned this Sep 1, 2023
@rlskoeser rlskoeser changed the title As a content editor, I want to save a published editorial as a PDF so that I can deposit it or share it in a more recognized academic format. As a user, I want to download a PDF and cite a published editorial so that I can deposit it or share it in a more recognized academic format. Sep 1, 2023
@mnaydan
Copy link
Contributor

mnaydan commented Sep 1, 2023

Questions:

  • Is the DOI supposed to link to the item? The full DOI displayed on editorial page, but took me to doi.org when clicked.
  • Link style for PDF functional but could be prettier (incorporates the preceding slash):
    Screenshot 2023-09-01 at 4 02 33 PM
  • Zotero harvested Item Type, Title, Abstract (just beginning of full text), Publication (Princeton Prosody Archive), Date, Language, DOI, ISSN, URL, and Library Catalog. It did not harvest author. Author ORCID isn't in there either, and I'm not sure where I would check to find the ORCID.
    Citation looks like: “How to Teach Prosody.” Princeton Prosody Archive, March 6, 2019. https://doi.org/10.5281/zenodo.8292370.

@mnaydan
Copy link
Contributor

mnaydan commented Sep 1, 2023

Also as discussed on Slack I think the Publication should be "Princeton Prosody Archive Editorial"

@rlskoeser
Copy link
Contributor Author

rlskoeser commented Sep 1, 2023

@mnaydan the doi won't resolve if it hasn't been published yet; if you want you could test with a SW doi that has been published.

Ugh about author metadata for zotero! That's important, I'll investigate.

I thought I fixed that underline on the slash next to the pdf, I'll look again.

I can update journal title to add "Editorial" as we discussed. Seem ok to you to still use the main ISSN for PPA?

@rlskoeser
Copy link
Contributor Author

I confirmed that the author orcid is in the metadata in the header.

@mnaydan
Copy link
Contributor

mnaydan commented Sep 1, 2023

I did test with a published DOI (CDH Charter) and it still went to doi.org

@rlskoeser
Copy link
Contributor Author

@mnaydan thanks for testing the doi! I'll look into it

@rlskoeser
Copy link
Contributor Author

@mnaydan I've updated the code and pushed changes to the test site that should address the DOI url problem and also fix the metadata citation problem you found; please confirm when you're able or let me know if there are still problems.

@mnaydan
Copy link
Contributor

mnaydan commented Sep 5, 2023

@rlskoeser

  1. Tested with an existing CDH charter DOI & it linked as expected. Fixed!
  2. PDF underline style fixed.
  3. Zotero harvested author and editor! Looks good :)

Also for documentation's sake, we changed our mind on Slack and the journal title will stay "Princeton Prosody Archive," as we decided there wasn't really any benefit to distinguishing between PPA & PPA Editorial & taking S&Co as a model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants