Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect aggregated cluster URLs to main search page so that bots stop causing errors by crawling those fake URLs #619

Closed
3 tasks done
mnaydan opened this issue Mar 18, 2024 · 2 comments
Assignees
Labels

Comments

@mnaydan
Copy link
Contributor

mnaydan commented Mar 18, 2024

This should help us with #597

testing notes

  • archive search urls with multiple clusters should redirect to the main archive search with no additional parameters (sample test url)
  • archive search should work normally without a cluster parameter (does not redirect)
  • search within a single cluster should work as before (does not redirect)
@mnaydan mnaydan added the bug label Mar 18, 2024
rlskoeser added a commit that referenced this issue Mar 19, 2024
* Implement and test 303 redirect for multiple cluster params

fixes #619

* Fix incorrect mock patch target
rlskoeser added a commit that referenced this issue Mar 19, 2024
* Implement and test 303 redirect for multiple cluster params

fixes #619

* Fix incorrect mock patch target
@mnaydan
Copy link
Contributor Author

mnaydan commented Mar 20, 2024

I tested with your sample URL & this one and they both redirect to main search as expected. I also tested by clicking on a cluster, then clicking "Search the full archive" which is how we produced the problem URL, and it redirects to main instead as expected (I think this was included in the last production release). (Note that the problem URL is still a valid URL: https://test-prosody.cdh.princeton.edu/archive/?cluster=&page=1 -- will that be an issue?

As far as I can tell, main search and search within cluster work normally (do not redirect).

@mnaydan
Copy link
Contributor Author

mnaydan commented Mar 20, 2024

Rebecca confirmed that the empty cluster param is equivalent to no cluster param and should not cause an issue, so we can close!

@mnaydan mnaydan closed this as completed Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants