Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal scroll & multiple languages seen in contextual notes #270

Closed
gwijthoff opened this issue May 25, 2022 · 7 comments
Closed

Horizontal scroll & multiple languages seen in contextual notes #270

gwijthoff opened this issue May 25, 2022 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@gwijthoff
Copy link
Contributor

During the copyediting process, Camey noticed a long horizontal scroll in the contextual notes, and both English and Spanish text appearing one after the other. Her screenshot is below. She got this effect on Chrome and Safari.

Screen Shot 2022-05-24 at 8 58 24 PM

@gwijthoff gwijthoff added the bug Something isn't working label May 25, 2022
@gwijthoff
Copy link
Contributor Author

Camey says she's on a Mac, but is also seeing the behavior on her phone. It's just a few notes, not all of them.

@rlskoeser
Copy link
Contributor

@gwijthoff what branch is this happening on?

@gwijthoff
Copy link
Contributor Author

@rlskoeser Editorial staging. I see it now too in Safari. And that was just a citation source in Spanish, so the Spanish edition footnotes aren't in there (phew!). I think the problem is that long URLs don't wrap like they do in Firefox:

https://startwords-dev-pr-263.onrender.com/issues/3/on-spanish-parrots/

@rlskoeser
Copy link
Contributor

@gwijthoff the details you provide for these bugs are so helpful! It was absolutely the url, and I have a one-line css fix to make it wrap in safari. Is it ok to commit this change to your editorial branch?

@gwijthoff
Copy link
Contributor Author

@rlskoeser please do! Thanks.

rlskoeser added a commit that referenced this issue May 25, 2022
@rlskoeser
Copy link
Contributor

pushed a fix to the editorial staging branch

@gwijthoff
Copy link
Contributor Author

Resolved by 711abf1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants