Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translator should only be named beneath Spanish introduction #289

Closed
gwijthoff opened this issue Jul 26, 2022 · 3 comments
Closed

translator should only be named beneath Spanish introduction #289

gwijthoff opened this issue Jul 26, 2022 · 3 comments
Assignees
Labels
chore One-off task
Milestone

Comments

@gwijthoff
Copy link
Contributor

Currently, at the base of the Issue 3 introduction in English, the translator's name is mentioned. I'm not wedded to this, but it might make sense only to include the translator's name beneath the Spanish version that he translated.

@gwijthoff gwijthoff added the chore One-off task label Jul 26, 2022
@rlskoeser rlskoeser added this to the Issue 3 milestone Jul 26, 2022
@rlskoeser
Copy link
Contributor

@gwijthoff just looked at the template, it's supposed to be displaying as "Spanish translation by ..." but we're missing the english translation for Español in our translation files. Current implementation would list all translated languages and translators on all pages (once we add the languages to our translation files).

Let me know what you prefer:

  • always display all translators and languages
  • only display translator for the current version (with no language indicator, I guess?)

@gwijthoff
Copy link
Contributor Author

gwijthoff commented Jul 27, 2022

@rlskoeser Ah, gotcha. In that case, it seems option 1 is better: always display all translators and languages.

@gwijthoff
Copy link
Contributor Author

resolved by #292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore One-off task
Projects
None yet
Development

No branches or pull requests

2 participants