Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On mobile, IIIF figures don't allow the user to scroll #323

Closed
gwijthoff opened this issue Sep 1, 2023 · 3 comments
Closed

On mobile, IIIF figures don't allow the user to scroll #323

gwijthoff opened this issue Sep 1, 2023 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@gwijthoff
Copy link
Contributor

When scrolling down Nick & Gian's SW4 article on mobile, the user gets trapped when they reach a IIIF figure. The IIIF image takes up the entirety of the screen, and when attempting to scroll lower down in the article, the user is only able to move the IIIF image around.

@gwijthoff gwijthoff added the bug Something isn't working label Sep 1, 2023
@rlskoeser
Copy link
Contributor

@gwijthoff good catch, thanks for flagging; is the height generally good and we should just set a mobile-specific style to make sure we limit it so we don't make a scroll trap?

@gwijthoff
Copy link
Contributor Author

@rlskoeser the height of the image itself is good, i.e. leaves enough space to touch outside the image. But the whitespace surrounding that image (part of the IIIF viewer? I don't know) seems to be what takes up the entirety of the mobile screen.

gwijthoff added a commit that referenced this issue Sep 7, 2023
Limit deep zoom height on mobile to avoid scroll traps #323
@rlskoeser
Copy link
Contributor

fix merged into develop in PR #330

@gwijthoff gwijthoff added this to the Issue 4 milestone Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants