Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing spacing between intro text and feature text on homepage #343

Closed
gwijthoff opened this issue Sep 12, 2023 · 2 comments
Closed

Missing spacing between intro text and feature text on homepage #343

gwijthoff opened this issue Sep 12, 2023 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@gwijthoff
Copy link
Contributor

Maybe this is a result of adding the publication date to the homepage, between issue number and issue title?

Main Develop
Screenshot 2023-09-12 at 1 18 07 PM Screenshot 2023-09-12 at 1 18 19 PM

Also this is making me realize we'll probably have to turn off the language toggles for Issue 4 but that is probably YET ANOTHER ISSUE?

@gwijthoff gwijthoff added the bug Something isn't working label Sep 12, 2023
@gwijthoff gwijthoff added this to the Issue 4 milestone Sep 12, 2023
@rlskoeser
Copy link
Contributor

The missing space isn't related to the addition of the publication date. I think it is most likely a bug in the implementation of spacing for more than two features; we just didn't notice because since this is our first new issue. You can tell because the space looks better when you configure issue 4 to have three features instead of 2. I'll investigate.

Language toggles are automatic and only appear when a page or issue is available in translation. They need to stay on the homepage because the site is available in translation, even if this particular issue is not.

gwijthoff added a commit that referenced this issue Sep 18, 2023
…acing

Fix spacing for homepage issue with 2 feature articles #343
@gwijthoff
Copy link
Contributor Author

Resolved in #349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants