Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm, functions/AccumulatorIntegrator: Add compilation support #2294

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

kmantel
Copy link
Collaborator

@kmantel kmantel commented Jan 22, 2022

This is helpful for testing the compiled Threshold condition

@kmantel kmantel requested a review from jvesely January 22, 2022 02:23
@github-actions
Copy link

This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):

No differences!

...

See CI logs for the full diff.

Copy link
Collaborator

@jvesely jvesely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to use a new random scalar for the tests?
Either way, LGTM

@github-actions
Copy link

This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):

No differences!

...

See CI logs for the full diff.

@kmantel
Copy link
Collaborator Author

kmantel commented Jan 25, 2022

Any reason to use a new random scalar for the tests? Either way, LGTM

I interpreted the random scalars as per parameter rather than as needed per test. I've changed it to use one of the existing ones.

@kmantel kmantel merged commit c58ad06 into PrincetonUniversity:devel Jan 25, 2022
@kmantel kmantel deleted the llvm branch January 25, 2022 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants