llvm/cuda: Optimize memory copies in memory execution #2328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
…echanism In reality we only use it in RTM. Reduces space needed for RO parameters: predator-prey: 7.73kB -> 5.96kB stability-flexibility: 8.84kB -> 5.75kB Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
…rwritten Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
… parameters The original approach created a copy to modulate mechanism parameters (if needed to apply mech parameter ports) and then passed this copy to internal function invocation. Invoking internal functions would then create more copies (if needed) to apply parameter ports of function parameters. The new approach passes the mechanism base parameters, so the copies of function parameters can be made from the original. The overall amount of copied data is the same, but now the same shared source is used for all copies This is especially beneficial for GPUs that place the shared parameters in high BW on-chip memories. The observed effect for stability-flexibility model is ~20% reduction in the total amount of data read from thread private memory, Resulting in ~10% improvement in kernel execution time. Measured on P620 GPU. Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
jvesely
added
compiler
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restrict 'has_initializers' parameter to mechanisms. This leaves most functions with parameters that are modified by parameter ports.
Don't copy base parameters to private parameter space if all of them will be replaced by parameter port outputs.
Use mechanism base params structure in places that don't modify parameters via parameter ports (e.g. running input/output ports). Unlike the modified result, which is private per evaluation, the base structure is shared.
This improves cache performance and memory utilization for both CPUs and GPUs.