llvm, mechanism: Eliminate redundant copies of port input data #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The types determines copy size, 'int' is secondary. Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
NFC. Potentialy faster execution postponing expensive 'isinstance' call. Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
Port inputs are constructed by combining input data and modulations in one structure. This is the case for all types of ports (input, output, parameter), since all can be modulated. Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
Drop exception path, exception handling is expensive. Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
Drop extra struct from the input type if there's no modulation. This allows us to use data inputs directly without creating an extra copy for port input. Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
OCM extracts 'optimal_samples' before returning its value, do that before calling the generic parser routine. Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
jvesely
changed the title
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports that are not modulated can directly use input data in its original location instead of creating a new copy.
Modulated ports still need a copy to create unified data+modulation input.
This saves ~12% of memory traffic in mechanism execution.
Add port modulation tests.