Fix/controlmechanism/assign as controller #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_instantiate_output_states():
reverted to ordinary instantation of default ControlSignal if none specified
fixed typo in owner attribute description
_instantiate_output_states():
reverted to ordinary instantation of default ControlSignal if none specified
* • System
- show_graph():
fixed bug producing empty image for graphs with just one Mechanism
added auto-recurrent projections
* • Log
- added numpy_array output method
* -
* -
* -
* -
* -
* -
* -
* -
* -
* -
* -
* -
* -
* • Log
- fixed bugs preventing logging during INITIALIZATION
* • Log
- fixed bugs preventing logging during INITIALIZATION
* -
* -
* -
* -
* -
* • Log
- logged_item, print_entries: corrected to use 'value' rather than owner's name in reports
* • Log
- logged_item, print_entries: corrected to use 'value' rather than owner's name in reports
• Tests
test_log: added test_log_initialization
* • Log
- _alias_owner_name: added to used 'value' rather than owner's name in reports
- nparray: bug fix to handle None values
• Tests
test_log: added test_log_initialization
* • Log
- log_value: added
• Tests
- test_multilayer: added test of log_value
* • Log
- log_value: implemented
- logged_item, print_entries: corrected to use 'value' rather than owner's name in reports
• Tests
- test_multilayer: added test of log_value
* • Log
- log_value: implemented
- logged_item, print_entries: corrected to use 'value' rather than owner's name in reports
• Tests
- test_multilayer: added test of log_value
* -
* • Component
- moved value property to Component (from Mechanism, Projection and State)
(left an override on ControlSignal that needs it for the getter)
* • Log
- docstring: added hint about using call_before_trial and call_after_trial
to log values
* -
* -
* • ObjectiveMechanism
_instantiate_input_states(): corrected to used monitored_output_state_specs
* • System
_instantiate_controller():
added assignment of controller.control_signals to self.control_signals
* -
* • ControlMechanism
_instantiate_output_states():
modifed to not instantiate a default OutputState
if no ControlSignals are specified
* • ControlMechanism
_instantiate_output_states():
reverted to ordinary instantation of default ControlSignal if none specified
* • ControlMechanism
_instantiate_output_states():
reverted to ordinary instantation of default ControlSignal if none specified
* • System
_get_monitored_output_states_for_system():
fixed bug in which string and tuple specifications were ignored
* • System
_get_monitored_output_states_for_system():
fixed bug in which string and tuple specifications were ignored
* • System
_get_monitored_output_states_for_system():
fixed bug in which string and tuple specifications were ignored
* -
* -
* -
LinearCombination()._validate_params:
fixed check on length of weight and exponents
…' of https://github.com/PrincetonUniversity/PsyNeuLink into fix/controlmechanism/assign_as_controller
LinearCombination()._validate_params:
fixed check on length of weight and exponents
* • System
- show_graph():
fixed bug producing empty image for graphs with just one Mechanism
added auto-recurrent projections
* • Log
- added numpy_array output method
* -
* -
* -
* -
* -
* -
* -
* -
* -
* -
* -
* -
* -
* • Log
- fixed bugs preventing logging during INITIALIZATION
* • Log
- fixed bugs preventing logging during INITIALIZATION
* -
* -
* -
* -
* -
* • Log
- logged_item, print_entries: corrected to use 'value' rather than owner's name in reports
* • Log
- logged_item, print_entries: corrected to use 'value' rather than owner's name in reports
• Tests
test_log: added test_log_initialization
* • Log
- _alias_owner_name: added to used 'value' rather than owner's name in reports
- nparray: bug fix to handle None values
• Tests
test_log: added test_log_initialization
* • Log
- log_value: added
• Tests
- test_multilayer: added test of log_value
* • Log
- log_value: implemented
- logged_item, print_entries: corrected to use 'value' rather than owner's name in reports
• Tests
- test_multilayer: added test of log_value
* • Log
- log_value: implemented
- logged_item, print_entries: corrected to use 'value' rather than owner's name in reports
• Tests
- test_multilayer: added test of log_value
* -
* • Component
- moved value property to Component (from Mechanism, Projection and State)
(left an override on ControlSignal that needs it for the getter)
* • Log
- docstring: added hint about using call_before_trial and call_after_trial
to log values
* -
* -
* • ObjectiveMechanism
_instantiate_input_states(): corrected to used monitored_output_state_specs
* • System
_instantiate_controller():
added assignment of controller.control_signals to self.control_signals
* -
* • ControlMechanism
_instantiate_output_states():
modifed to not instantiate a default OutputState
if no ControlSignals are specified
* • ControlMechanism
_instantiate_output_states():
reverted to ordinary instantation of default ControlSignal if none specified
* • ControlMechanism
_instantiate_output_states():
reverted to ordinary instantation of default ControlSignal if none specified
* • System
_get_monitored_output_states_for_system():
fixed bug in which string and tuple specifications were ignored
* • System
_get_monitored_output_states_for_system():
fixed bug in which string and tuple specifications were ignored
* • System
_get_monitored_output_states_for_system():
fixed bug in which string and tuple specifications were ignored
* -
* -
* -
* • Function
LinearCombination()._validate_params:
fixed check on length of weight and exponents
* • Function
LinearCombination()._validate_params:
fixed check on length of weight and exponents
- added input_states as argument to constructor
- added input_states as argument to constructor
- added input_states as argument to constructor • System, ControlMechanism, EVCControlMechanism - clean-up for assign_as_controller
…' of https://github.com/PrincetonUniversity/PsyNeuLink into fix/controlmechanism/assign_as_controller
* • System
- show_graph():
fixed bug producing empty image for graphs with just one Mechanism
added auto-recurrent projections
* • Log
- added numpy_array output method
* -
* -
* -
* -
* -
* -
* -
* -
* -
* -
* -
* -
* -
* • Log
- fixed bugs preventing logging during INITIALIZATION
* • Log
- fixed bugs preventing logging during INITIALIZATION
* -
* -
* -
* -
* -
* • Log
- logged_item, print_entries: corrected to use 'value' rather than owner's name in reports
* • Log
- logged_item, print_entries: corrected to use 'value' rather than owner's name in reports
• Tests
test_log: added test_log_initialization
* • Log
- _alias_owner_name: added to used 'value' rather than owner's name in reports
- nparray: bug fix to handle None values
• Tests
test_log: added test_log_initialization
* • Log
- log_value: added
• Tests
- test_multilayer: added test of log_value
* • Log
- log_value: implemented
- logged_item, print_entries: corrected to use 'value' rather than owner's name in reports
• Tests
- test_multilayer: added test of log_value
* • Log
- log_value: implemented
- logged_item, print_entries: corrected to use 'value' rather than owner's name in reports
• Tests
- test_multilayer: added test of log_value
* -
* • Component
- moved value property to Component (from Mechanism, Projection and State)
(left an override on ControlSignal that needs it for the getter)
* • Log
- docstring: added hint about using call_before_trial and call_after_trial
to log values
* -
* -
* • ObjectiveMechanism
_instantiate_input_states(): corrected to used monitored_output_state_specs
* • System
_instantiate_controller():
added assignment of controller.control_signals to self.control_signals
* -
* • ControlMechanism
_instantiate_output_states():
modifed to not instantiate a default OutputState
if no ControlSignals are specified
* • ControlMechanism
_instantiate_output_states():
reverted to ordinary instantation of default ControlSignal if none specified
* • ControlMechanism
_instantiate_output_states():
reverted to ordinary instantation of default ControlSignal if none specified
* • System
_get_monitored_output_states_for_system():
fixed bug in which string and tuple specifications were ignored
* • System
_get_monitored_output_states_for_system():
fixed bug in which string and tuple specifications were ignored
* • System
_get_monitored_output_states_for_system():
fixed bug in which string and tuple specifications were ignored
* -
* -
* -
* • Function
LinearCombination()._validate_params:
fixed check on length of weight and exponents
* • Function
LinearCombination()._validate_params:
fixed check on length of weight and exponents
* • IntegratorMechanism
- added input_states as argument to constructor
* • IntegratorMechanism
- added input_states as argument to constructor
* • IntegratorMechanism
- added input_states as argument to constructor
• System, ControlMechanism, EVCControlMechanism
- clean-up for assign_as_controller
* -
- fixed bug with matrix specification for monitored_output_states
- fixed bug with matrix specification for monitored_output_states
- fixed bug in assign_as_controller for controller with existing monitored_output_states
- fixed bug in assign_as_controller for controller with existing monitored_output_states
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• System, ControlMechanism, ObjectiveMechanism
- fixed bug with matrix specification for monitored_output_states
- fixed bug in assign_as_controller for controller with existing monitored_output_states