Fixed bug in MosaicCrystal when normal is in the 'z' direction.

PrincetonUniversity · Mar 8, 2023 · 35ebab6 · 35ebab6
1 parent 69ca0f6
commit 35ebab6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/xicsrt/optics/_InteractCrystal.py b/xicsrt/optics/_InteractCrystal.py
@@ -23,7 +23,7 @@ class InteractCrystal(InteractMirror):
 
     def default_config(self):
         """
-        crystal_spacing
+        crystal_spacing: float [angstroms]
           The spacing between crystal planes.
 
           .. Note::

diff --git a/xicsrt/optics/_InteractMosaicCrystal.py b/xicsrt/optics/_InteractMosaicCrystal.py
@@ -122,9 +122,9 @@ def mosaic_normals(self, normals, mask, copy=True):
 
         R = np.empty((np.sum(m), 3, 3,), dtype=np.float64)
 
-        # Create two vectors perpendicular to the surface normal,
+        # Create two vectors perpendicular to the surface normal and each other,
         # it doesn't matter how they are oriented otherwise.
-        R[:, 0, :]  = np.cross(normals[m], [0,0,1])
+        R[:, 0, :]  = np.cross(normals[m], [1,0,0]) + np.cross(normals[m], [0,0,1])
         R[:, 0, :] /= np.linalg.norm(R[:, 0, :], axis=1)[:, np.newaxis]
         R[:, 1, :]  = np.cross(normals[m], R[:, 0, :])
         R[:, 1, :] /= np.linalg.norm(R[:, 1, :], axis=1)[:, np.newaxis]