Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 닉네임, 전화번호, 프로필 사진 URI 필드를 Member로 이동 #65

Merged
merged 8 commits into from
Jun 3, 2024

Conversation

scv1702
Copy link
Member

@scv1702 scv1702 commented May 16, 2024

✨ 구현한 기능

  • 닉네임, 전화번호, 프로필 사진 URI 필드를 Member로 이동

📢 논의하고 싶은 내용

  • 도메인 레이어와 서비스 레이어를 얼마나 분리/의존하게 만들어야 하는지 고민이네요. 단순한 CRUD 로직을 도메인 레이어에 작성할지, 아니면 서비스 레이어에 작성할지 참 어렵습니다.

🎸 기타

Copy link

github-actions bot commented May 16, 2024

Test Results

82 tests  +1   82 ✅ +1   20s ⏱️ -1s
57 suites +3    0 💤 ±0 
57 files   +3    0 ❌ ±0 

Results for commit bb3f7a7. ± Comparison against base commit 88b1011.

♻️ This comment has been updated with latest results.

Copy link
Member

@wlgns12370 wlgns12370 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@scv1702 scv1702 merged commit 2976982 into develop Jun 3, 2024
2 checks passed
@scv1702 scv1702 deleted the feature/member-entity-rft branch June 3, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants