Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MWP-287] Support new Cura 5.0 updates #293

Merged
merged 5 commits into from
May 25, 2022
Merged

[MWP-287] Support new Cura 5.0 updates #293

merged 5 commits into from
May 25, 2022

Conversation

Elkin-Vasily
Copy link
Collaborator

@Elkin-Vasily Elkin-Vasily commented May 17, 2022 •
edited

closes #287
closes #299

@Elkin-Vasily Elkin-Vasily added the pull request: dependencies Pull requests that update a dependency file or api version label May 17, 2022
@Elkin-Vasily Elkin-Vasily added this to the next milestone May 17, 2022
@Elkin-Vasily Elkin-Vasily added this to In progress in MKS WiFi Plugin via automation May 17, 2022
@Jeredian Jeredian mentioned this pull request May 21, 2022
Closed
@sonarcloud
Copy link

sonarcloud bot commented May 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

MKS WiFi Plugin automation moved this from In progress to Reviewer approved May 25, 2022
Jeredian
Jeredian approved these changes May 25, 2022
View reviewed changes
Copy link
Collaborator

@Jeredian Jeredian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue were described in #301 . They are minor, so it's not a blocker right now.
Tested on OSX and Win 10.

@Jeredian Jeredian merged commit 023eb26 into develop May 25, 2022
MKS WiFi Plugin automation moved this from Reviewer approved to Done May 25, 2022
@Jeredian Jeredian deleted the issue-287 branch May 25, 2022 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeredian Jeredian Jeredian approved these changes

Assignees
No one assigned
Labels
pull request: dependencies Pull requests that update a dependency file or api version
Projects
No open projects
MKS WiFi Plugin
Done
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Can't save thumb in Cura 5.0.0 Support new Cura 5.0 updates
2 participants
@Elkin-Vasily @Jeredian