Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add es_ES locale #324

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Add es_ES locale #324

merged 2 commits into from
Jul 7, 2022

Conversation

JPBarrio
Copy link
Contributor

@JPBarrio JPBarrio commented Jul 3, 2022

Not getting used to github procedures. Just have translated mksplugin.mo into Spanish using poedit. Created new folder es_ES as told and then new file, then create pull request...

@Jeredian
Copy link
Collaborator

Jeredian commented Jul 3, 2022

@Elkin-Vasily , can you please review this PR, because you more familiar with translation than I am.

@Jeredian Jeredian added the pull request: community Improvements or additions from the community label Jul 3, 2022
@Elkin-Vasily
Copy link
Collaborator

The file you have added is not .mo file it is .po.
.mo file is not human-readable.

Just rename your mksplugin.mo to mksplugin.po.
.mo should be generated automatically.

@JPBarrio
Copy link
Contributor Author

JPBarrio commented Jul 4, 2022 via email

@Elkin-Vasily Elkin-Vasily changed the title Create mksplugin.mo Add es_ES locale Jul 7, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Elkin-Vasily Elkin-Vasily added this to In progress in MKS WiFi Plugin via automation Jul 7, 2022
@Elkin-Vasily Elkin-Vasily moved this from In progress to Reviewer approved in MKS WiFi Plugin Jul 7, 2022
@Jeredian Jeredian merged commit 889d6e2 into PrintMakerLab:develop Jul 7, 2022
MKS WiFi Plugin automation moved this from Reviewer approved to Done Jul 7, 2022
@Jeredian Jeredian mentioned this pull request Jul 7, 2022
@JPBarrio JPBarrio deleted the patch-1 branch July 10, 2022 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request: community Improvements or additions from the community
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants