Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded qmlregister type #375

Merged

Conversation

nallath
Copy link
Contributor

@nallath nallath commented Aug 2, 2023

In pyqt6 you can only register 60 types. If you install all plugins in Cura, you run into this issue. Since this type isn't used, its better to not register it as this leaves more breathing room for the rest

In pyqt6 you can only register 60 types. If you install all plugins in Cura, you
run into this issue. Since this type isn't used, its better to not register it
as this leaves more breathing room for the rest
@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Elkin-Vasily Elkin-Vasily added the pull request: community Improvements or additions from the community label Aug 4, 2023
@Elkin-Vasily Elkin-Vasily added this to In progress in MKS WiFi Plugin via automation Aug 4, 2023
@Elkin-Vasily Elkin-Vasily added this to the next milestone Aug 4, 2023
MKS WiFi Plugin automation moved this from In progress to Reviewer approved Aug 4, 2023
@Jeredian Jeredian merged commit dda8ba3 into PrintMakerLab:develop Sep 29, 2023
1 of 2 checks passed
MKS WiFi Plugin automation moved this from Reviewer approved to Done Sep 29, 2023
@nallath nallath deleted the Remove_unneeded_qml_register_type branch October 9, 2023 08:33
@Jeredian Jeredian mentioned this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request: community Improvements or additions from the community
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants