add description to explain Drive Prefix #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobafetthotmail
requested review from
Jeredian and
Elkin-Vasily
as code owners
1 task
Jeredian
requested changes
Nov 13, 2023
bobafetthotmail
force-pushed
the
patch-1
branch
from
29ac158
to
63fc215
Compare
added a description so people know how to configure the Drive Prefix setting for their printer. added missing anchors to fix a layout issue in the popup. Since after adding the instruction label the print/delete buttons were moved to the right and not visible anymore
bobafetthotmail
force-pushed
the
patch-1
branch
from
63fc215
to
71e5a2e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Now it should be ok, I edited the label text and I used Since to fix this I had to open the file on my PC, the text editor program I use auto-deleted the "space bar characters" at the empty line 238 too. |
Elkin-Vasily
approved these changes
Nov 14, 2023
Jeredian
approved these changes
Nov 14, 2023
|
closes #371 |
Closed
Jeredian
added
the
pull request: community
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a description so people know how to configure Drive Prefix setting for their printer.
I moved the Print/Delete buttons to the left because after I added the description row they were moved too much to the right. I could not figure out a better way to fix the alignment issue.