Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change initialization of simage and gimage variables #404

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

Jeredian
Copy link
Collaborator

@Jeredian Jeredian commented Feb 21, 2024

Description

This fixes error: local variable referenced before assignment

Type of change

What kind of change does this PR introduce?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Translations
  • Documentation
  • Other... Please describe:

What is the current behavior?

image

What is the new behavior(if this is a feature change)?

No error shown

image

How has this been tested?

  • Disable "preview" settings, or choose "FLSUN QQ-S" printer
  • Slice model
  • Try to save on local disk, or upload to the printer
  • Error will be shown

  • Tested on MacOS
  • Tested on Windows

Does this PR introduce a breaking change?

  • Yes
  • No

Does it closes one of the existing issues?

  • Yes
  • No

Fixes #403

Other information

PR Checklist:

  • The pull request opens from the issue/patch/feature/bugfix branch (right side) and not main branch!
  • The pull request title, commit messages and code are follows our guidelines: Contribution guide
  • All commits are signed-off. See How to sign-off commit
  • The code changes are commented, particularly in hard-to-understand areas

Signed-off-by: Pavel Polyakov <djeredian@gmail.com>
Copy link

sonarcloud bot commented Feb 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Jeredian Jeredian added the pull request: bug Pull request with changes related to behavior that is considered incorrect label Feb 21, 2024
@Jeredian Jeredian marked this pull request as ready for review February 21, 2024 09:17
@Jeredian Jeredian merged commit 8a98758 into develop Feb 21, 2024
6 of 7 checks passed
@Jeredian Jeredian deleted the issue-403 branch February 21, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request: bug Pull request with changes related to behavior that is considered incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.4.4] Plugin crashes with unassigned variable alert.
2 participants