Skip to content

Commit

Permalink
Update website page styles to not interfere with themes (#1952)
Browse files Browse the repository at this point in the history
This changes the `style.css` to not interfere with themes. 

The problem was that `* { ...; font-weight: normal; }` caused markdowns bold text to not be rendered as bold. 

<details>
<summary>Style inheritance</summary>

![image](https://user-images.githubusercontent.com/20878432/60092675-e90e2000-9747-11e9-8b16-73bf3e219001.png)

</details>

The fix is quite simple: I just removed the `font-weight: normal;` line. The only elements (besides the bold tokens) that changed were `h2`s, so they get a new rule. In a side-to-side comparison, I wasn't able to spot any other differences.

Result:

![image](https://user-images.githubusercontent.com/20878432/60092899-5e79f080-9748-11e9-955c-bd3645fc018e.png)
  • Loading branch information
RunDevelopment authored and mAAdhaTTah committed Jun 29, 2019
1 parent 5ab28bb commit b654385
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion style.css
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ footer p {
* {
margin: 0;
padding: 0;
font-weight: normal;
}

body {
Expand Down Expand Up @@ -77,6 +76,10 @@ h2 {
margin: 1em 0 .3em;
}

h2 {
font-weight: normal;
}

dt {
margin: 1em 0 0 0;
font-size: 130%;
Expand Down

0 comments on commit b654385

Please sign in to comment.