Add the C++11 raw string feature to the cpp language #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should fix issue #1253 |
Golmote
reviewed
Dec 27, 2017
components/prism-cpp.js
Outdated
|
|
||
| Prism.languages.insertBefore('cpp', 'string', { | ||
| 'raw-string': { | ||
| pattern: /R"([^()\ ]{0,16})\([\s\S]*\)\1"/, |
There was a problem hiding this comment.
There is no need to escape the space char in the char class, is there?
Also, the part in the parentheses looks greedy: does this mean R"(foo)"R"(bar)" is a single string?
There was a problem hiding this comment.
Hi @Golmote, thanks for the review. Yes you are correct. My intention was not to escape the space char, but to exclude the backslash. It should be \\ instead of a single \. You are also correct in that R"(foo)"R"(bar)" should not be a single string. I guess my regex skills are getting a bit rusty 😄 I'll fix it...
|
@zeitgeist87 Great! Looks good to me now. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.