Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .token.class-name to rest of themes #1360

Merged
merged 6 commits into from
Jun 5, 2018
Merged

Conversation

paladox
Copy link
Contributor

@paladox paladox commented Mar 17, 2018

No description provided.

@Golmote
Copy link
Contributor

Golmote commented Mar 20, 2018

Hi, thanks for taking care of this.

I noticed the Tomorrow Night theme and the Coy theme already have the class-name handled actually, so there should be nothing to change in these files.

On the contrary, we should add support for it in the Solarized Light theme.

The change in the Okaidia theme looks good to me.

@mAAdhaTTah
Copy link
Member

@paladox Would love to get this in. Would you be able to make the minor changes requested here?

@paladox
Copy link
Contributor Author

paladox commented Jun 4, 2018

Done.

Copy link
Member

@mAAdhaTTah mAAdhaTTah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @Golmote This cover all your changes?

@mAAdhaTTah mAAdhaTTah changed the base branch from gh-pages to master June 5, 2018 20:15
@Golmote
Copy link
Contributor

Golmote commented Jun 5, 2018

@mAAdhaTTah No, the changes in themes/prism-coy.css and themes/prism-tomorrow.css need to be reverted. Those themes already handle the class-name token (line 149 in Coy, and 79 in Tomorrow).

@paladox
Copy link
Contributor Author

paladox commented Jun 5, 2018

@Golmote done.

@Golmote Golmote merged commit f356dfe into PrismJS:master Jun 5, 2018
@Golmote
Copy link
Contributor

Golmote commented Jun 5, 2018

@paladox Thank you!

@paladox
Copy link
Contributor Author

paladox commented Jun 5, 2018

your welcome :).

@paladox paladox deleted the patch-3 branch June 5, 2018 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants