Modify attr-name regex to include fields with arguments #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm very green at Prism themes and Regex, so I'd love if someone would sanity-check this. But it seems like the current GraphQL component doesn't apply `attr-name` class to schema fields with attributes (e.g. `user(id: ID!): User`). I did my best Googling and tried to modify the regex syntax to also include cases where colon is after a set of parenthesis.
RunDevelopment
requested changes
Jan 17, 2019
There was a problem hiding this comment.
Thank you for contributing!
I left you a little comment concerning your regex.
You also have to run npx gulp (Gulp) to create the minified files.
|
Thank you for contributing! |
Merged
This was referenced Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm very green at Prism themes and Regex, so I'd love if someone would sanity-check this. But it seems like the current GraphQL component doesn't apply
attr-nameclass to schema fields with attributes (e.g.user(id: ID!): User).I did my best Googling and tried to modify the regex syntax to also include cases where colon appears after a set of parenthesis.