Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom class: Implemented TODOs #1873

Merged
merged 1 commit into from
May 8, 2019
Merged

Custom class: Implemented TODOs #1873

merged 1 commit into from
May 8, 2019

Conversation

RunDevelopment
Copy link
Member

This PR allows for map to take functions as an argument.

This indirectly fixes the TODOs as both can be trivially implemented using a mapper function.

mAAdhaTTah
mAAdhaTTah approved these changes May 8, 2019
View reviewed changes
Copy link
Member

@mAAdhaTTah mAAdhaTTah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bearing with me; lgtm!

@RunDevelopment RunDevelopment merged commit acceb3b into PrismJS:master May 8, 2019
@RunDevelopment RunDevelopment deleted the custom-class-todos branch May 8, 2019 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mAAdhaTTah mAAdhaTTah mAAdhaTTah approved these changes

Assignees
No one assigned
Labels
enhancement needs review plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RunDevelopment @mAAdhaTTah