Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown: Added support for auto-loading code block languages #1898

Merged
merged 7 commits into from
Jul 22, 2019

Conversation

RunDevelopment
Copy link
Member

This resolves #1644.

Autoloader now also exposes a loadLanguages function which, in contrast to the private loadLanguages, guarantees that callbacks are executed asynchronously.

Copy link
Contributor

@ExE-Boss ExE-Boss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r+

plugins/autoloader/prism-autoloader.js Outdated Show resolved Hide resolved
@mAAdhaTTah
Copy link
Member

Thought: are we better off adding extra code so the public API so it's always async or fix the internal implementation to be always async?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown should auto load languages
3 participants