Download page: Improved performance for chromium based browsers #1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RunDevelopment
changed the title
mAAdhaTTah
reviewed
Jun 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have this issue that when I selected all languages on the download page, Chrome freezes for about 12 seconds (!!) while using FireFox/Edge this operation takes an instant.
Btw. CPU: Intel i7-8700K @ 4.2GHz. (On my laptop, Chrome takes about 30sec)
This PR fixes this issue and after the fix, Chome takes less than a 1sec (not ideal but ok). FF and Edge stay fast.
Here are some profiling results (Chrome):
Before
TLDR;
Scripting: 177ms
Rendering: 11,485ms
After
TLDR;
Scripting: 121ms // no idea why this is suddenly faster
Rendering: 592ms