Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protobuf improvements #1948

Merged
merged 3 commits into from
Jul 1, 2019
Merged

Protobuf improvements #1948

merged 3 commits into from
Jul 1, 2019

Conversation

RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Jun 21, 2019 •
edited
Loading

Some major improvements to the Protobuf language.

Apart from services, this should support full Protobuf 2 and Protobuf 3 syntax.
This also adds an example page.

Example (Outdated)

image

mAAdhaTTah
mAAdhaTTah approved these changes Jun 30, 2019
View reviewed changes
Copy link
Member

@mAAdhaTTah mAAdhaTTah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really review this, but the tests look good, and the example improvements are great, so maybe just give it a second look and merge?

@RunDevelopment RunDevelopment merged commit de10bd1 into PrismJS:master Jul 1, 2019
@RunDevelopment RunDevelopment deleted the protobuf-improvements branch July 1, 2019 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mAAdhaTTah mAAdhaTTah mAAdhaTTah approved these changes

Assignees
No one assigned
Labels
enhancement language-definitions needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RunDevelopment @mAAdhaTTah