Added test for unused capturing groups #1996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would we be able to use the new dependency loader for testing the peer dependencies? |
|
Yes, #1998, which I want to land because I'm getting bugs on the babel plugin that I want to verify is fixed by this. |
cedporter
pushed a commit
to cedporter/prism
that referenced
this pull request
Oct 17, 2019
This adds a test that checks for unused capturing groups in patterns and another test which ensures that lookbehind groups are always the first thing being matched in a pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test which checks for whether there are unused capturing groups in a pattern.
Edit: I added another test which ensures that lookbehind groups are always the first thing being matched in a pattern.
The new test does this by parsing every pattern using regexpp. This is a quite costly operation but it only doubles the test time from 0.5s to 1s one my machine so it's not even close to the 7s for the >1.3k language tests.
@Golmote once went on a killing spree to eliminate every last unused capturing group and this test makes sure that no new ones get added.