Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Groovy: Minor improvements #2036

Merged
merged 1 commit into from
Sep 2, 2019
Merged

Groovy: Minor improvements #2036

merged 1 commit into from
Sep 2, 2019

Conversation

RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Sep 1, 2019 •
edited
Loading

This makes some minor improvements to the Groovy language definition.

  • Triple quoted strings now support backslash escapes
  • A single . will now be highlighted as punctuation instead of operator to be consistent with other languages.

I also wanted to fix slash strings but I don't think that possible without either creating an AST or very very complex patterns (see TODO).

mAAdhaTTah
mAAdhaTTah approved these changes Sep 2, 2019
View reviewed changes
Copy link
Member

@mAAdhaTTah mAAdhaTTah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@RunDevelopment RunDevelopment merged commit fb61833 into PrismJS:master Sep 2, 2019
@RunDevelopment RunDevelopment deleted the groovy-improvements branch September 2, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mAAdhaTTah mAAdhaTTah mAAdhaTTah approved these changes

Assignees
No one assigned
Labels
enhancement language-definitions needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RunDevelopment @mAAdhaTTah