Add undefined to Typescript keywords #2088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RunDevelopment
requested changes
Oct 13, 2019
There was a problem hiding this comment.
Thank you for this PR @ChristianIvicevic!
LGTM, but please revert the changes to package-lock.json. After that is done, we can merge this.
|
@RunDevelopment npm decided to update the lockfile automatically, I just reverted the automated changes and only included my addition to the Typescript component files. |
RunDevelopment
approved these changes
Oct 13, 2019
|
Thank you for contributing! |
cedporter
pushed a commit
to cedporter/prism
that referenced
this pull request
Oct 17, 2019
This adds `undefined` to the list of keywords in TypeScript.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add
undefinedto the list of keywords for Typescript that was missing so far.