Rename robot-framework to robotframework #2113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM; Just the CI. I don't get why it failed. I'll look into it. |
|
I might have been naive in just sed’ing and renaming files... |
|
Found it. Please run gulp. Uglify found some things to optimize. Just run the following command and everything should be fine. |
|
Thanks. I also found the tests and there is still places to fix... |
|
Better now. Thanks for help. |
RunDevelopment
approved these changes
Nov 15, 2019
|
Thank you for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for highlighting Robot Framework plain text syntax was added in #2034 and I'm so grateful for that.
Unfortunately, as my mistake, I forgot to mention that the canonical name for the language in various context has used to be
robotframeworkwithoud dash, notrobot-framework.Since there is has not been release yet for prism since the addition of the language, it should be safe to still do the rename. I tried to the rename in this pull.