Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VB.NET - Quotes break on included '@' symbol #2781

Closed
dipsylala opened this issue Mar 2, 2021 · 2 comments · Fixed by #2782
Closed

VB.NET - Quotes break on included '@' symbol #2781

dipsylala opened this issue Mar 2, 2021 · 2 comments · Fixed by #2782

Comments

@dipsylala
Copy link

Information

  • Language: VB.NET
  • Plugins: None

Description
When quote marks include an '@' sign the opening quotes are not recognised

In the following example, The first line is shown incorrectly highlighted, the second works.

bob = new SqlCommand("Select * from test Where Code=@Code");
bob = new SqlCommand("Select * from test Where Code=Code");

image

Test page

Would this be as simple as adding '@' to prism-basic.js's string pattern? I'm wary of potential regression issues. on other languages that extend it.

'string': {
		pattern: /"(?:""|[@!#$%&'()*,\/:;<=>?^_ +\-.A-Z\d])*"/i,
		greedy: true
	},
@dipsylala dipsylala changed the title VB.NET - Quotes VB.NET - Quotes break on included '@' symbol Mar 2, 2021
@RunDevelopment
Copy link
Member

Would this be as simple as adding '@' to prism-basic.js's string pattern?

That would be possible but a better solution is to override the pattern in VB.net. I'll make a PR.

@dipsylala
Copy link
Author

Perfect - thanks for the quick response :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants