Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update highlighting for Swift #3171

Closed
1 task
AvdLee opened this issue Oct 28, 2021 · 4 comments · Fixed by #3174
Closed
1 task

Update highlighting for Swift #3171

AvdLee opened this issue Oct 28, 2021 · 4 comments · Fixed by #3174

Comments

@AvdLee
Copy link
Contributor

AvdLee commented Oct 28, 2021

Information

  • Language: Swift
  • Plugins: 'none'

Description
#3022 was a great improvement for Swift, but there are simply more keywords we can support.

image

That's actually all I kind find right now, so we're in a good spot!!

@RunDevelopment
Copy link
Member

Good find!

Would you like to make a PR @AvdLee?

@AvdLee
Copy link
Contributor Author

AvdLee commented Oct 29, 2021

@RunDevelopment normally I wouldn't even open this issue since it's only one keyword, though, since this is in the method body I wasn't sure how to solve this. It's not like simply adding an extra keyword since this keyword is already in the list of recognised keywords.

It should work like inout which is also placed in front:

func doubleInPlace(number: inout Int) {
    number *= 2
}

We do seem to support that variant, so I wonder why the isolated isn't working in this case 🤔

@RunDevelopment
Copy link
Member

It's not like simply adding an extra keyword since this keyword is already in the list of recognised keywords.

No, it's just that easy because it's not in that list, only nonisolated is.

@AvdLee
Copy link
Contributor Author

AvdLee commented Nov 1, 2021

No, it's just that easy because it's not in that list, only nonisolated is.

I did not realise that! Let me open a PR 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants