Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git component improvements #401

Closed
wants to merge 2 commits into from
Closed

Git component improvements #401

wants to merge 2 commits into from

Conversation

TimothyGu
Copy link
Contributor

--- and +++ should be highlighted as well, as they really make the entire output look nicer and easier to see the green lines are in this file.

This is especially important when highlighting plain diff files that are not generated by Git, because in that case the original and new file names are different.

Ping @lgiraudel, maintainer of the Git component.

This is more consistent with other syntax highlighting engines like GitHub's
and Pygment.

Signed-off-by: Timothy Gu <timothygu99@gmail.com>
Signed-off-by: Timothy Gu <timothygu99@gmail.com>
@TimothyGu
Copy link
Contributor Author

Any news on this PR? (Ping @lgiraudel again)

@lgiraudel
Copy link
Contributor

Hi,

It's in my todo list to check it but I won't be able to merge it in master.

@LeaVerou
Copy link
Member

LeaVerou commented Dec 1, 2014

That’s fine, I can merge it. I was just waiting for your feedback @lgiraudel :)

@lgiraudel
Copy link
Contributor

Ok, I'll check the two commits today then.

@lgiraudel
Copy link
Contributor

I don't know if in most console the filenames in git diff are in red and green but in the one I used as reference (bash console in ubuntu), the filenames are in white bold.

But we can apply the green / red color, it's not illogical...

@TimothyGu
Copy link
Contributor Author

@lgiraudel although Git doesn't highlight it, most highlighting engine highlights it (and I feel it's better), including:

Even those that don't highlight the lines as red and green at least have some styles for these lines, including:

(there should be more)

I don't object to add some styles that are different from addition/deletion, but it seems to me that just using add/del colors is the simplest.

@Golmote Golmote closed this in 3aadd5d Sep 14, 2015
@TimothyGu TimothyGu deleted the match-all branch September 14, 2015 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants