Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL highlighting #485

Closed
LeaVerou opened this issue Jan 21, 2015 · 3 comments
Closed

URL highlighting #485

LeaVerou opened this issue Jan 21, 2015 · 3 comments

Comments

@LeaVerou
Copy link
Member

This issue is more of a note to self, as I'd love to write this myself when I get some time.

The lang definition would go through all existing languages and replace url tokens with itself as inside. Then it would highlight data URIs (e.g. SVG in data URIs, like this), it could highlight hashes and query params and many other things.

Thoughts? Do you guys think it would be useful?

@Golmote
Copy link
Contributor

Golmote commented Feb 1, 2015

This may not be easy, since data URIs can contain pretty much anything, right?

Also, this should probably be a plugin.

@LeaVerou
Copy link
Member Author

LeaVerou commented Feb 1, 2015

Of course it wouldn’t be in Core, I was planning to have it as a language definition.

Re:data URIs, I meant the urlencoded ones (which these days can have no urlencoded characters at all, as few characters really need escaping in them)

@Golmote
Copy link
Contributor

Golmote commented Feb 1, 2015

If it is as a language definition, then could it be used in combination with another language definition?
In the example you gave, with the data URI containing SVG inside CSS, how will it be possible to highlight both the CSS and the content of the data URI (as markup) if it's implemented as a language definition?

What I meant about the contents of the data URI is that it may need to be highlighted as markup (like in your example, again) or as pretty much anything else depending on the mime type used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants