Add Keyman language highlighting #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,14 @@ | |||
| Prism.languages.keyman = { | |||
| 'comment': /\b[cC]\s.*?(\r?\n|$)/, | |||
There was a problem hiding this comment.
You can simplify the regexp by using the i flag.
Also, I think you can remove the last part ?(\r?\n|$) since the dot . does not match line feeds. (Unless you intentionally wanted to consume the line feed?)
|
Thanks for contributing. Please take a look at my comments. |
|
Thanks for the deep review. I think all comments addressed, a couple of extra minor tweaks as well. |
|
Thanks, this looks good to me now. |
LeaVerou
added a commit
that referenced
this pull request
Jun 28, 2015
Add Keyman language highlighting
|
Merged, thank you both! |
|
Thank you both as well -- that's how a pull request should always work :) Smooth as. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Keyman / KMFL language highlighting, as documented at http://help.keyman.com/developer/9.0/docs/