Apply suggestions from code review

Co-authored-by: Sefa Eyeoglu <contact@scrumplex.net> Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
PrismLauncher · Jan 13, 2023 · f7b0ba8 · f7b0ba8
1 parent 574af2c
commit f7b0ba8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/launcher/Application.cpp b/launcher/Application.cpp
@@ -266,7 +266,8 @@ Application::Application(int &argc, char **argv) : QApplication(argc, argv)
         m_zipsToImport.append(QUrl::fromLocalFile(QFileInfo(zip_path).absoluteFilePath()));
     }
 
-    for (auto zip_path : parser.positionalArguments()){ // treat unspesified positional arguments as import urls
+    // treat unspecified positional arguments as import urls
+    for (auto zip_path : parser.positionalArguments()) {
         m_zipsToImport.append(QUrl::fromLocalFile(QFileInfo(zip_path).absoluteFilePath()));
     }
 

diff --git a/launcher/ui/MainWindow.cpp b/launcher/ui/MainWindow.cpp
@@ -1816,7 +1816,7 @@ void MainWindow::processURLs(QList<QUrl> urls)
 {
     // NOTE: This loop only processes one dropped file!
     for (auto& url : urls) {
-        qDebug() << "Processing :" << url;
+        qDebug() << "Processing" << url;
 
         // The isLocalFile() check below doesn't work as intended without an explicit scheme.
         if (url.scheme().isEmpty())
@@ -1832,9 +1832,7 @@ void MainWindow::processURLs(QList<QUrl> urls)
 
         auto type = ResourceUtils::identify(localFileInfo);
 
-        // bool is_resource = type;
-
-        if (!(ResourceUtils::ValidResourceTypes.count(type) > 0)) {  // probably instance/modpack
+        if (ResourceUtils::ValidResourceTypes.count(type) == 0) {  // probably instance/modpack
             addInstance(localFileName);
             continue;
         }