Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev build] Crash on mass mod update #1638

Closed
1 task done
ColonelGerdauf opened this issue Sep 21, 2023 · 4 comments · Fixed by #1694
Closed
1 task done

[dev build] Crash on mass mod update #1638

ColonelGerdauf opened this issue Sep 21, 2023 · 4 comments · Fixed by #1694
Labels
bug Something isn't working
Milestone

Comments

@ColonelGerdauf
Copy link
Contributor

Operating System

Windows

Version of Prism Launcher

8.0-develop (latest)
Commit: 98bc102

Version of Qt

Qt 6.5.2

Description of bug

I believe this relies on an instance with a large amount of mods, and a lot of mods with updates.

Reading the log file, there is a very large chunk filled with NULL, which makes it very difficult to post in here or mclo.gs

Steps to reproduce

  • get an instance with 200+ mods
  • have a large amount of them awaiting an update (?)
  • hit "update" on unselected or after CTRL-A
  • proceed with the update request
  • wait for the updates to complete

*- and Prism crashes

Suspected cause

A stack overflow or data overload of some kind. It is possible that I ran into this bug by chance and the causes I have cited are not related.

This issue is unique

  • I have searched the issue tracker and did not find an issue describing my bug.
@ColonelGerdauf ColonelGerdauf added the bug Something isn't working label Sep 21, 2023
@Trial97
Copy link
Member

Trial97 commented Sep 22, 2023

Can you still post that log file?
I tried to reproduce your crash without success:

  • Download a older version of AllTheMods8(for the huge number of mods)
  • Update the mods
  • Results in 231 mods to be updated
  • Works

Also can you reproduce it or it was one time thing?

@ColonelGerdauf
Copy link
Contributor Author

It appears to be a one-time bug. I am less sure now on what is happening.
I have no clue in which log file to look at anymore, given the one that seemed to show the bug was riddled with NULL statements in one part, which make uploading impossible it seems.

What situation would even cause a crash on update confirmation?

@Trial97
Copy link
Member

Trial97 commented Sep 28, 2023

It is complicated: there is no clear reason why it would crash(we try to not add stuff that may crash).
Even with logs is hard to determine what happens and where it crashed, without them is nearly impossible.
Also it doesn't help if we can't reproduce it.

@HyperSoop
Copy link
Contributor

I think I've had the mod updater crash the launcher too at some point. It's unclear what exactly causes such a crash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants