Improvements to concurrent tasks

[Trial97]

I did get a crash:

• add a new instance
• technic
• Attack for B team latest version: https://www.technicpack.net/modpack/attack-of-the-bteam.552556
• click OK
• after it starts to download mods click on abort
• I get a crash

Env:

• latest develop (a7bdfb5)
• Qt 6.5.3
• Number of concurrent tasks 24
• Number of concurrent downloads 6

I have high hopes that this may solve some other issues regarding concurrent tasks

Here are some of the fixed issues:

• fixes [dev build] Crash on mass mod update #1638 (I was able to reproduce it and fix it)
• fixes Prism Launcher can crash when clicking OK button in update mods screen #659 (same as above)
• fixes Prismlauncher segfaults when updating instance #1430(same as above)
• fixes Updating already updated instances crashes the launcher #689
• fixes Crashes when I exit after aborting mod update #1340 (this is the same issue described in this PR)
• fixes Quick scrolling of the modpack list at adding instance screen crashes the app on windows 10 #863
• fixes Launcher freezes/crashes after scrolling through Modrinth modpacks (Linux) #664
• fixes Show error on failed version refresh #157 (we already have the messagebox but NetJob did not ever fail; prior to this PR)
• fixes Crash when searching by author in Curseforge tab by Copy Paste Then Manually Searching for Another Author (Finicky bug) #1899 (2d91bd0)
• fixes Resolve dependencies when updating mods #1263 (comment) on 463ff4c
• fixes Installing a CurseForge modpack can silently fail to download some mods. #1919 (by the fact that now concurrent task fails if one task fails)

Once this is released we should notify:

• Prism Launcher Crashing when try to install a Modpack #1299
• Macos Crash when Switching Between Modrinth and Curseforge while Searching #1205
• 7.0 Crash when choosing mod #1138
• Mac M1 Crash on CurseForge modpack update #936

[Trial97]

Removed from milestone until I have a clear idea for this

[Trial97]

This is the successor of #1364.
Right now this is not stable (tests may still fail on actions).
I need to test most tasks(similar to the old PR)

[Trial97]

Now that I magically solved the action tests, here is a list with all the stuff I will test in order to see if this works or not:(with asan)

ConcurrentTask

• Create a Custom instance
• Create an Import instance:
  • from URL
  • from Curseforge URL
  • Curseforge
  • Modrinth
  • Prism
• Create an AtLauncher instance
• Create a Curseforge instance
  • with blocked mods
• Create a Ftb Legacy instance:
  • public
  • Third Party
  • Private
• Create a Ftb App Import instance
• Create a Modrinth instance
• Create a Technic instance
• try to abort the task when it's running for the add instance action
• Update mods:
  • with metadata
  • without metadata
  • dependency
• Export pack:
  • Prism
  • Modrinth
  • Curseforge
• Download:
  • mods
  • mods with dependency
  • resource packs
  • shaders
  • textures
• That resources are correctly displayed(mods/resource packs/shaders/textures)

SequentialTask

• Imgur Uplad with album
• Skin upload
• update mods
• check for mods dependencies

NetJob

• all download dialogs:
  • Curseforge
  • Modrinth
• all mod packs
• the mod/mod pack/resource description is loaded correctly
• the meta (versions and loaders)
• the asset download (the stuff that is prompted right before you play the game)
• all loaders work(with libraries and stuff):
  • vanilla
  • forge
  • neoforge
  • fabric
  • quilt
  • litleloader
• the online resource logo loads correctly
• the news is loaded
• the translation is loading
• the curseforge modpack import works (from website)
• the curseforge mod import works (from website)
• managed pack page works:
  • Curseforge
  • Modrinth
  • and version change for both providers
  • and version refresh for both providers
• Imgur upload

extra

• about dialog
• account list page works
• try to move through the resource lists rapidly

MultipleOptionsTask is not used so there is no test for it

** This list is not final, it's just a list from a quick search through code for ConccurentTask stuff. If I missed any test case let me know.

• I will reset this list if I make changes to the PR(meaning I need to test all cases again)

[Trial97]

Tested all that complicated stuff and it all works now.
With that, this is ready to review and test.
As I modified the ConncurentTask stuff I expect at least one other person(or more) will test this PR.
And a small question for somebody with more qt knowledge:
If I define a QSharedPointer, then connect a signal from that pointer to lambda and capture sharedPointer through value; Will that pointer be deleted automatically, or do I need some code that calls deleteLater or disconnect on that pointer?

[Trial97]

Now this was tested with asan enabled so we should be good on the memory side

[TayouVR]

I am not super confident in my testing, but I was not able to create a crash or otherwise bad behaviour... so it looks good to me.
More people please test!

[github-actions]

Backport failed because this pull request contains merge commits. You can either backport this pull request manually, or configure the action to skip merge commits.