Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

right click- open with- prism launcher (zip/mrpack) doesn't work on linux #581

Closed
1 task done
DioEgizio opened this issue Dec 10, 2022 · 3 comments · Fixed by #696
Closed
1 task done

right click- open with- prism launcher (zip/mrpack) doesn't work on linux #581

DioEgizio opened this issue Dec 10, 2022 · 3 comments · Fixed by #696
Labels
bug Something isn't working
Milestone

Comments

@DioEgizio
Copy link
Member

Operating System

Linux

Version of Prism Launcher

develop

Version of Qt

qt 5.15.7

Description of bug

right click- open with- prism launcher should open the modpack/rpack installing dialog with zip/mrpack, but it just gives... nothing

Steps to reproduce

  • right click- open with- prism launcher on a zip or a mrpack
  • see prism launching normally

Suspected cause

idk but when opening on a terminal

prismlauncher path/to/file

it gives

QLocalSocket::setServerName() called while not in unconnected state

This issue is unique

  • I have searched the issue tracker and did not find an issue describing my bug.
@DioEgizio DioEgizio added the bug Something isn't working label Dec 10, 2022
@Scrumplex
Copy link
Member

Was Prism already running? I assume this isn't passed to the already running app using LocalPeer

@DioEgizio
Copy link
Member Author

For the error in terminal yeah, but right click-open with- prism launcher doesn't work even when prism is closed

@Ryex
Copy link
Contributor

Ryex commented Dec 14, 2022

This is because the open-with command on Linux is relying on the .desktop file and not passing the -I flag.
Personally I think that if passed a positional argument that is a file path Prism should detect that file type and handle it accordingly.

Scrumplex added a commit that referenced this issue Jan 16, 2023
@Scrumplex Scrumplex added this to the 7.0 milestone Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants