Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Java automatically #734

Open
1 task done
lynrayy opened this issue Jan 10, 2023 · 20 comments · May be fixed by #2069
Open
1 task done

Download Java automatically #734

lynrayy opened this issue Jan 10, 2023 · 20 comments · May be fixed by #2069
Labels
enhancement New feature or request

Comments

@lynrayy
Copy link

lynrayy commented Jan 10, 2023

Role

Player, new users of Prism

Suggestion

Prism launcher should automatically install java for selected minecraft version

Benefit

Prism launcher will be more user-friendly with this feature

This suggestion is unique

  • I have searched the issue tracker and did not find an issue describing my suggestion, especially not one that has been rejected.

You may use the editor below to elaborate further.

Some people are repelled by the fact that you have to manually install and set java in Prism (j1.8 or j17). Therefore, it will be great if the launcher acts as an official launcher, GDLauncher, CurseForge and other user-friendly launchers

@lynrayy lynrayy added the enhancement New feature or request label Jan 10, 2023
@ghost
Copy link

ghost commented Jan 10, 2023

This is already being done #285

@lynrayy
Copy link
Author

lynrayy commented Jan 10, 2023

Nope, it's not done

@ghost
Copy link

ghost commented Jan 10, 2023

I mean it's being worked on

@lynrayy

This comment was marked as off-topic.

@lynrayy
Copy link
Author

lynrayy commented Jan 10, 2023

I mean it's being worked on

Ok

@DioEgizio

This comment was marked as off-topic.

@lynrayy

This comment was marked as off-topic.

@TheKodeToad
Copy link
Member

TheKodeToad commented Jan 11, 2023

The simple answer is because it's not finished yet. It is being worked on by timoreo22.

@DioEgizio

This comment was marked as off-topic.

@lynrayy

This comment was marked as off-topic.

@DioEgizio

This comment was marked as off-topic.

@lynrayy

This comment was marked as off-topic.

@DioEgizio

This comment was marked as off-topic.

@TheKodeToad
Copy link
Member

TheKodeToad commented Jan 11, 2023

I don't think anyone thinks this is a bad idea (well, perhaps MultiMC did but I don't know) - it's simply not fully implemented yet. Nobody said you should have to do it manually.

@Scrumplex
Copy link
Member

The simple answer to why this isn't a thing yet is, that the set of developers and the set of users having issues installing Java does not overlap mostly.

I just use my distribution's package manager to get my Java versions. You can do the same using WinGet on Windows. I would personally never use a JRE bundled by a launcher, if I could just use the one packaged by my distribution.
Though I am not opposed to this feature in any way.

If anyone wants to implement this, go ahead and we might merge it. Though it is quite complex, considering the way we do Java currently.

This feature request has been a thing ever since PolyMC was initially forked from MultiMC, which was over a year ago by now.

@Scrumplex Scrumplex changed the title Auto install java Download Java automatically Jan 11, 2023
@TheKodeToad
Copy link
Member

TheKodeToad commented Jan 11, 2023

Even if you look at IntelliJ IDEA - which is made for Java developers - it has this feature. Eclipse and NetBeans don't though - although Eclipse bundles a default version similar to how Prism does (Prism unfortunately only on Flatpak).

@DioEgizio
Copy link
Member

Yeah I think java downloading/management is a very important feature

@Minenash
Copy link

Unfortunately the lack of this feature is the main reason why none of my friends ended up sticking to any MMC based launcher. The first time I helped them install java, but (at the time) downloading for Windows wasn't the most user friendly thing, so if they ever got a new computer or reinstalled their os, they didn't want to deal with the hassle of installing Java to have the launcher even work, and especially once Minecraft started updating which Java it used causing them to have to install it again (and even just having the latest isn't enough, because old versions don't work with Java 9 or higher)

@TheAirBlow
Copy link

TheAirBlow commented Feb 18, 2023

Unfortunately the lack of this feature is the main reason why none of my friends ended up sticking to any MMC based launcher. The first time I helped them install java, but (at the time) downloading for Windows wasn't the most user friendly thing, so if they ever got a new computer or reinstalled their os, they didn't want to deal with the hassle of installing Java to have the launcher even work, and especially once Minecraft started updating which Java it used causing them to have to install it again (and even just having the latest isn't enough, because old versions don't work with Java 9 or higher)

Personally it would be worth it for me. It isn't hard to do in any way or capacity, and takes like 5 minutes, and you get the best modding UX afterwards... And it's not like you have to install a lot of versions, it is just 17, 11 and 8. If you don't play the version range that uses for example java 8 you can just skip it.

Although I do think java management is good in terms of UX, but please, dead god, do it only for Windows, Linux has package managers!

Unpopular opinion: this is a barrier to keep zero effort Windows users from Prism. Also, do not eat me alive, this is an obvious joke!

@leumasme
Copy link
Contributor

The simple answer to why this isn't a thing yet is, that the set of developers and the set of users having issues installing Java does not overlap mostly. [...] You can do the same using WinGet on Windows.

I personally get my Java via Scoop on Windows. This works very well, but It's still not a clean experience with Prism Launcher because I still have to check which Java version is the correct one for the current Minecraft version whenever I create a new Instance.

@Ryex Ryex mentioned this issue Apr 20, 2023
1 task
@Trial97 Trial97 linked a pull request Feb 9, 2024 that will close this issue
38 tasks
Mowstyl pushed a commit to Mowstyl/PrismLauncher that referenced this issue May 24, 2024
nix: add package argument for extra jdks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants