Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick scrolling of the modpack list at adding instance screen crashes the app on windows 10 #863

Closed
1 task done
ksoczowka opened this issue Feb 14, 2023 · 4 comments · Fixed by #1694
Closed
1 task done
Labels
bug Something isn't working
Milestone

Comments

@ksoczowka
Copy link

Operating System

Windows

Version of Prism Launcher

Prism Launcher 6.3

Version of Qt

Qt 6.4.2

Description of bug

When in new instance screen and want to get a new modpack. When you scroll quickly the app crashes!

Steps to reproduce

  • Go to Adding new instance menu
  • Select Modrinth/CurseForge
  • Scroll down with mouse quickly
  • Crash

Suspected cause

It only occurs when the images doesn't load yet so I think it could be that app is trying to access the value of a page that doesn't exist so app is throwing an range error.
On the other hand I don't know, because there is no error message after the crash.

This issue is unique

  • I have searched the issue tracker and did not find an issue describing my bug.
@ksoczowka ksoczowka added the bug Something isn't working label Feb 14, 2023
@TayouVR
Copy link
Member

TayouVR commented Feb 14, 2023

can reproduce, issue seems to be caused by our ConcurrentTask
image
https://github.com/PrismLauncher/PrismLauncher/blob/develop/launcher/tasks/ConcurrentTask.cpp#L118

@ksoczowka
Copy link
Author

May I try to fix this bug? I want to contribute to this project

@TayouVR
Copy link
Member

TayouVR commented Feb 15, 2023

go ahead!
I am currently occupied with other tasks and my personal life, any contribution is welcome!

@Trial97
Copy link
Member

Trial97 commented Jun 28, 2023

Can you try the nightly build(https://nightly.link/PrismLauncher/PrismLauncher/actions/runs/5394098599) and see if this is still reproducing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants