Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance Description displays the last launch date #1025

Merged
merged 4 commits into from Apr 27, 2023

Conversation

hideki2k02
Copy link
Contributor

Initial Draft using the Standard C++ Library, still requires testing.

Initial Draft using the Standard C++ Library, still requires testing.

Signed-off-by: Japa <japa4551@protonmail.com>
launcher/minecraft/MinecraftInstance.cpp Outdated Show resolved Hide resolved
Co-authored-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
Signed-off-by: Japa <japa4551@protonmail.com>
@hideki2k02
Copy link
Contributor Author

Thanks Ryex! You've tried explaining on Discord but i was not really sure on how to work (whilst knowing exactly what i was doing) with QLocale and QDateTime, and since i already have a (kinda) working thing i've decided to Draft it.

@hideki2k02
Copy link
Contributor Author

image
I've just finished building it and it is working as intended

If you're a language maintainer, i'm sorry for this haha

@hideki2k02 hideki2k02 marked this pull request as ready for review April 21, 2023 15:39
Copy link
Contributor

@Ryex Ryex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple change indeed. kinda wish I could set tags.

@Scrumplex Scrumplex added enhancement New feature or request simple change labels Apr 21, 2023
@Scrumplex Scrumplex added this to the 7.0 milestone Apr 21, 2023
Co-authored-by: Sefa Eyeoglu <contact@scrumplex.net>
Signed-off-by: Japa <japa4551@protonmail.com>
Copy link
Contributor

@flowln flowln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't it be 'Last played on <date> for <time>'? 🤔

idk, my english isn't that good 😔

valeu! ^-^

Signed-off-by: Japa <japa4551@protonmail.com>
@hideki2k02
Copy link
Contributor Author

wouldn't it be 'Last played on for '? thinking

idk, my english isn't that good pensive

valeu! ^-^

Definitivamente! I dont know how that got past everyone haha

Copy link
Contributor Author

@hideki2k02 hideki2k02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, i've fixed the typo.

@Scrumplex Scrumplex merged commit f54fc16 into PrismLauncher:develop Apr 27, 2023
14 checks passed
@Scrumplex
Copy link
Member

Thanks!

@hideki2k02 hideki2k02 deleted the lastLaunchTimeDate branch April 29, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request simple change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants